Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bls Pairing check optimisation: skip exp for infinity #7883

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Bls Pairing check optimisation: skip exp for infinity #7883

merged 3 commits into from
Dec 11, 2024

Conversation

Marchhill
Copy link
Contributor

@Marchhill Marchhill commented Dec 10, 2024 •
edited
Loading

Changes

  • Skip exponentiation if infinity point found

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Passes state tests

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

@Marchhill Marchhill changed the title Bls Pairing check optimisation Bls Pairing check optimisation: skip exp for infinity Dec 10, 2024
@Marchhill Marchhill marked this pull request as ready for review December 11, 2024 11:41
MarekM25
MarekM25 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if confirmed with tests

@Marchhill Marchhill merged commit 3afdc81 into master Dec 11, 2024
79 checks passed
@Marchhill Marchhill deleted the perf/bls-pairing-skip-exp branch December 11, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarekM25 MarekM25 MarekM25 approved these changes

@LukaszRozmej LukaszRozmej Awaiting requested review from LukaszRozmej

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Marchhill @MarekM25