Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getters, Config to be upgradeable, Ownable2Step #55

Merged
merged 7 commits into from
Aug 14, 2024

Conversation

EgeCaner
Copy link
Contributor

No description provided.

@@ -49,13 +49,15 @@ pub mod MultiTokenCategoryRegistry {
component!(path: SRC5Component, storage: src5, event: SRC5Event);

#[abi(embed_v0)]
impl OwnableMixinImpl = OwnableComponent::OwnableMixinImpl<ContractState>;
impl OwnableTwoStepImpl = OwnableComponent::OwnableTwoStepImpl<ContractState>;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Mixin?, in pwn_config it was not, so I kept this way. Let me know if it needs to be mixin

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2steps is good

Copy link
Collaborator

@ametel01 ametel01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@@ -49,13 +49,15 @@ pub mod MultiTokenCategoryRegistry {
component!(path: SRC5Component, storage: src5, event: SRC5Event);

#[abi(embed_v0)]
impl OwnableMixinImpl = OwnableComponent::OwnableMixinImpl<ContractState>;
impl OwnableTwoStepImpl = OwnableComponent::OwnableTwoStepImpl<ContractState>;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2steps is good

@ametel01 ametel01 merged commit 16c6fb4 into NethermindEth:main Aug 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants