-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getters, Config to be upgradeable, Ownable2Step #55
Conversation
@@ -49,13 +49,15 @@ pub mod MultiTokenCategoryRegistry { | |||
component!(path: SRC5Component, storage: src5, event: SRC5Event); | |||
|
|||
#[abi(embed_v0)] | |||
impl OwnableMixinImpl = OwnableComponent::OwnableMixinImpl<ContractState>; | |||
impl OwnableTwoStepImpl = OwnableComponent::OwnableTwoStepImpl<ContractState>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be Mixin?, in pwn_config
it was not, so I kept this way. Let me know if it needs to be mixin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2steps is good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
@@ -49,13 +49,15 @@ pub mod MultiTokenCategoryRegistry { | |||
component!(path: SRC5Component, storage: src5, event: SRC5Event); | |||
|
|||
#[abi(embed_v0)] | |||
impl OwnableMixinImpl = OwnableComponent::OwnableMixinImpl<ContractState>; | |||
impl OwnableTwoStepImpl = OwnableComponent::OwnableTwoStepImpl<ContractState>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2steps is good
No description provided.