Eventexample #593
Open
Eventexample #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagodeev
requested changes
Jul 16, 2024
There was a problem hiding this comment.
Hi @alex-sumner, sorry for the delay.
Great job, thank you! Left some comments
|
Also, could you change these READMEs to include this example? |
|
Hi @alex-sumner. Are you still available? |
|
Hi yes I amOn 2 Oct 2024, at 15:51, Thiago Ribeiro ***@***.***> wrote:
Hi @alex-sumner. Are you still available?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Could you please make the changes I mentioned? |
|
Yes, I willOn 2 Oct 2024, at 16:28, Thiago Ribeiro ***@***.***> wrote:
Could you please make the changes I mentioned?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Hi, I have pushed all the requested changes on my branch. |
|
Hi,
How's it going? I made all the requested changes on 10 November for
#593
Can this be merged?
Thanks,
Alex
…On Wed, 2 Oct 2024 at 16:28, Thiago Ribeiro ***@***.***> wrote:
Could you please make the changes I mentioned?
—
Reply to this email directly, view it on GitHub
<#593 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALA3NDFY57PDBSOCLSNVY6LZZQGJ5AVCNFSM6AAAAABKW6KFU6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBYHE3TGNJQGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi @alex-sumner. Sorry for the delay. |
|
Ok, thanksOn 16 Jan 2025, at 13:45, Thiago Ribeiro ***@***.***> wrote:
Hi @alex-sumner. Sorry for the delay.
We are really focused on RPCv0.8.0, that's why I still haven't reviewed your PR and others.
I'll do it ASAP when I finish RPCv08. Sorry for that
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example code for reading event logs, as called for in issue #578