Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

Plugin frontend refactor changes #106

Merged
merged 17 commits into from
May 30, 2024
Merged

Plugin frontend refactor changes #106

merged 17 commits into from
May 30, 2024

Conversation

satyambnsal
Copy link
Contributor

@satyambnsal satyambnsal commented May 27, 2024

Changes Summary

  • Add path alias support
  • Import variables naming changes
  • Import statements order sanity (external library imports followed by local imports)
  • Integrate Prettier with ESLInt for consistent formatting across all team member's devices
  • Use custom hooks useAsync and useTimeout for async and timeout effects.
  • Prefer using Named exports instead of default exports as you don't have to come up with a name when importing it.
  • Code formatting changes.

@satyambnsal satyambnsal requested a review from elataret May 29, 2024 08:18
@satyambnsal satyambnsal marked this pull request as ready for review May 29, 2024 08:18
Copy link
Contributor

@elataret elataret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the code locally with the Payable and Greeter contracts and seems to be working fine.

Copy link
Contributor

@elataret elataret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, looks good.

@elataret elataret requested a review from varex83 May 29, 2024 15:08
Copy link
Contributor

@varex83 varex83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@elataret elataret merged commit 9ffd2da into develop May 30, 2024
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants