Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

UI revamp changes #153

Merged
merged 16 commits into from
Jul 29, 2024
Merged

UI revamp changes #153

merged 16 commits into from
Jul 29, 2024

Conversation

satyambnsal
Copy link
Contributor

@satyambnsal satyambnsal commented Jul 15, 2024

Changes summary

#147
#148
#149
#150
#151
#114
#38

@satyambnsal satyambnsal marked this pull request as ready for review July 24, 2024 14:36
@satyambnsal satyambnsal requested a review from varex83 July 24, 2024 14:44
@varex83
Copy link
Contributor

varex83 commented Jul 25, 2024

image

I have some problems with paddings/margin here, can you fix it to be centered?

@varex83
Copy link
Contributor

varex83 commented Jul 25, 2024

image

also, remove this shadow under the env section

@varex83
Copy link
Contributor

varex83 commented Jul 25, 2024

image

nitpick, make it more table-like, and use tx hash instead of txid

@varex83
Copy link
Contributor

varex83 commented Jul 25, 2024

image

can we have the same width of dropdown as selector?

@varex83 varex83 requested a review from taco-paco July 25, 2024 19:36
@satyambnsal
Copy link
Contributor Author

@varex83 Thank you for the thorough review. I've addressed all the points raised, with one exception: changing the Transaction history table structure to a more table-like format. This modification would require good CSS changes, so I propose we handle this in a separate PR.
Here is how it looks after changing TxId to TxHash

Screenshot 2024-07-26 at 3 50 46 PM

@satyambnsal
Copy link
Contributor Author

Review changes done.

@satyambnsal satyambnsal requested review from varex83 and removed request for varex83 July 29, 2024 08:51
Copy link
Contributor

@varex83 varex83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

can you quickly add some margings there, and we are good to go?

@satyambnsal satyambnsal requested a review from varex83 July 29, 2024 12:27
Copy link
Contributor

@varex83 varex83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varex83 varex83 merged commit c9928d7 into develop Jul 29, 2024
3 checks passed
@varex83 varex83 deleted the feature/accordian-tab-ui-changes branch July 29, 2024 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants