Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add execution_state to each test #58

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

mull
Copy link
Collaborator

@mull mull commented Jan 20, 2022

For some reason this was removed.

To show the results for a test run we need to know:

  • How many tests were scheduled
  • Which of them are finished

This PR adds a column test_results.execution_state that can either be pending | completed | aborted (it is not related to the outcome of the test, only the execution.)

If a worker for a test fails this is picked up and written to Postgres.

This PR creates another issue: the result page crashes if a test fails (its execution_state is set to 'aborted'.) There is already a ticket to deal with this. If a test crashed previously the result was simply a never-ending loading page.

Since we don't have a migration system this is the DDL statement for the cluster:

CREATE TYPE execution_states AS ENUM ('pending', 'aborted', 'completed');

ALTER TABLE test_results 
  ADD COLUMN execution_status execution_states NOT NULL DEFAULT 'pending';

UPDATE test_results SET execution_status='completed';

@mull mull force-pushed the feature/add-status-for-individual-tests branch from cb07b13 to e5f9620 Compare January 21, 2022 07:13
@mull mull merged commit 54aa902 into main Jan 21, 2022
@mull mull deleted the feature/add-status-for-individual-tests branch January 21, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants