Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default for rpcError #1322

Merged
merged 4 commits into from
Aug 17, 2022
Merged

Set default for rpcError #1322

merged 4 commits into from
Aug 17, 2022

Conversation

gsteinLTU
Copy link
Member

Fix #1314

Is there something better than null we could use for "no RPC error"?

@gsteinLTU gsteinLTU requested a review from brollb August 12, 2022 22:16
@gsteinLTU
Copy link
Member Author

Now uses empty string instead of null

@brollb
Copy link
Collaborator

brollb commented Aug 17, 2022

I just remembered that some of the early NetsBlox projects used the following check for RPC errors:
myRole script pic (50)
Although this isn't really ideal, we should probably stick to the current convention (avoiding breaking changes) and should use null for now.

I am going to revert back to your original commit and merge. Thanks!

@brollb brollb merged commit ca3d48a into master Aug 17, 2022
@brollb brollb deleted the 1314-error-undefined branch August 17, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error block gives undefined
2 participants