Fix message type creation dialog #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brollb These are a bit of a hack, but it seems like the simplest way to make it work without having to modify the Snap code. The only issue is that if we ever have hint inputs supported in the block editor, multi-hint-arg inputs will have their number of values editable in the palette. Is it worth restricting it to only work inside dialog boxes and scripts? |
brollb
approved these changes
Sep 30, 2022
|
Looks good. Thanks, @gsteinLTU! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1326
Includes fix for
namefield and some minor improvements. The dialog now tells you when you didn't specify a name instead of closing immediately, the (functionless?) handle on the dialog is removed, and the name field has its initial hint text display correctly.