extend trusted sources #1345
Merged
extend trusted sources #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested it (Devin doesn't have the new setup running locally yet) and it worked to allow *.netsblox.org extensions along with localhost (when running on localhost), but not other domains. |
|
LGTM. However, I am not really convinced about the use case. @dragazo, why would you need an extension to load projects via URL? Why not use the existing URL parameters (eg, https://editor.netsblox.org/#open:https://raw.githubusercontent.com/NetsBlox/exercises/master/exercises/letter-frequency/parsons.xml)? (Since this seems like it could be useful for other use cases as well, it should be fine to merge anyway.) |
brollb
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curriculum project links (like https://curriculum.netsblox.org/9-week/dc/plot-co2-vs-temp.nb) work by redirecting to editor with an extension that loads the project xml we store. But currently this prompts for trusted sources every time. This PR extends trusted sources to every subdomain of
netsblox.org.