Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update rubocop and related gems (Oct 2023) #21

Merged
merged 3 commits into from
Oct 18, 2023

Conversation

zverok
Copy link
Contributor

@zverok zverok commented Oct 13, 2023

Change description

Updates all gems to the newest versions, where possible; adjusts config defaults accordingly.

Corresponding Server PR: https://github.com/NetsoftHoldings/hubstaff-server/pull/10692

Checklists

Development

  • The commit message follows our guidelines
  • I have performed a self-review of my own code
  • I have thoroughly tested the changes
  • I have added tests that prove my fix is effective or that my feature works

Security

  • Security impact of change has been considered

@zverok zverok added the code review needed Needs code review by engineer label Oct 13, 2023
@zverok zverok self-assigned this Oct 13, 2023
@zverok zverok force-pushed the chore-update-rubocop-oct-2023 branch from 7a4ee70 to 588a9e4 Compare October 18, 2023 17:32
@zverok zverok added code review passed Engineering signed off on changes and removed code review needed Needs code review by engineer labels Oct 18, 2023
@zverok zverok added the QA passed QA signed off on changes label Oct 18, 2023
@zverok
Copy link
Contributor Author

zverok commented Oct 18, 2023

@asaletnik @ayarotsky @urkle Can somebody merge & release that?.. I don't have enough rights 🙏

@asaletnik
Copy link
Contributor

@asaletnik @ayarotsky @urkle Can somebody merge & release that?.. I don't have enough rights 🙏

I can't - lets ask our current release manager @thiagogabriel

@thiagogabriel thiagogabriel added this to the Release 1.1.7 milestone Oct 18, 2023
@thiagogabriel thiagogabriel merged commit 720a48b into master Oct 18, 2023
5 checks passed
@thiagogabriel thiagogabriel deleted the chore-update-rubocop-oct-2023 branch October 18, 2023 18:20
@zverok
Copy link
Contributor Author

zverok commented Oct 18, 2023

@thiagogabriel Thanks! Did you released the new gem version too? My bundler can't install it yet 🤔

@thiagogabriel
Copy link

It was released while you typed :)
https://github.com/NetsoftHoldings/netsoft-rubocop/actions/runs/6564997241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code review passed Engineering signed off on changes QA passed QA signed off on changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants