Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Development gems dependency #22

Merged
merged 2 commits into from
Dec 19, 2023
Merged

fix: Development gems dependency #22

merged 2 commits into from
Dec 19, 2023
+13 −8

Conversation

zverok
Copy link
Contributor

@zverok zverok commented Dec 12, 2023

The adjustment made for Ruby 3.2 not to fail on CI was too eager a dependency.

Checklists

Development

  • The commit message follows our guidelines
  • I have performed a self-review of my own code
  • I have thoroughly tested the changes
  • I have added tests that prove my fix is effective or that my feature works

Security

  • Security impact of change has been considered

@zverok zverok added the code review needed Needs code review by engineer label Dec 12, 2023
@zverok zverok requested a review from urkle December 12, 2023 20:20
@urkle urkle added code review passed Engineering signed off on changes and removed code review needed Needs code review by engineer labels Dec 13, 2023
@urkle urkle added this to the Release 1.1.8 milestone Dec 13, 2023
@evertonts evertonts added the QA passed QA signed off on changes label Dec 19, 2023
@evertonts evertonts merged commit 34d1ae8 into master Dec 19, 2023
5 checks passed
@evertonts evertonts deleted the fix-gems-dependency branch December 19, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkle urkle urkle approved these changes

Assignees

@zverok zverok

Labels
code review passed Engineering signed off on changes QA passed QA signed off on changes
Projects
None yet
Milestone
Release 1.1.8
Development

Successfully merging this pull request may close these issues.
3 participants
@zverok @urkle @evertonts