Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scan): print warnings on scan run #544

Merged
merged 7 commits into from
May 14, 2024
Merged

feat(scan): print warnings on scan run #544

merged 7 commits into from
May 14, 2024

Conversation

nzvtrk
Copy link
Contributor

@nzvtrk nzvtrk commented May 13, 2024 •
edited
Loading

closes #545

@nzvtrk
Copy link
Contributor Author

nzvtrk commented May 13, 2024

need to be verified on one of environments

denis-maiorov-brightsec
denis-maiorov-brightsec requested changes May 13, 2024
View reviewed changes
src/Commands/RunScan.ts Outdated Show resolved Hide resolved
denis-maiorov-brightsec
denis-maiorov-brightsec approved these changes May 13, 2024
View reviewed changes
src/Commands/RunScan.ts Outdated Show resolved Hide resolved
src/Commands/RunScan.spec.ts Outdated Show resolved Hide resolved
denis-maiorov-brightsec
denis-maiorov-brightsec requested changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@denis-maiorov-brightsec denis-maiorov-brightsec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, misclicked approve
See #544 (comment) #544 (comment)

denis-maiorov-brightsec
denis-maiorov-brightsec requested changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@denis-maiorov-brightsec denis-maiorov-brightsec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Let's address a few minors and we're good to merge

src/Commands/RunScan.spec.ts Outdated Show resolved Hide resolved
src/Commands/RunScan.spec.ts Outdated Show resolved Hide resolved
src/Commands/RunScan.spec.ts Outdated Show resolved Hide resolved
src/Commands/RunScan.spec.ts Show resolved Hide resolved
src/Commands/RunScan.spec.ts Show resolved Hide resolved
src/Commands/RunScan.spec.ts Show resolved Hide resolved
src/Commands/RunScan.spec.ts Show resolved Hide resolved
src/Commands/RunScan.spec.ts Outdated Show resolved Hide resolved
src/Commands/RunScan.spec.ts Outdated Show resolved Hide resolved
denis-maiorov-brightsec
denis-maiorov-brightsec requested changes May 14, 2024
View reviewed changes
src/Commands/RunScan.spec.ts Outdated Show resolved Hide resolved
src/Commands/RunScan.spec.ts Outdated Show resolved Hide resolved
src/Commands/RunScan.spec.ts Outdated Show resolved Hide resolved
@denis-maiorov-brightsec denis-maiorov-brightsec merged commit 0b0b148 into next May 14, 2024
5 checks passed
@denis-maiorov-brightsec denis-maiorov-brightsec deleted the feat-1086/missing-test-warning branch May 14, 2024 14:02
@derevnjuk derevnjuk linked an issue Jun 27, 2024 that may be closed by this pull request
Enhance CLI Functionality for Monitoring Scan Process Issues #545
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denis-maiorov-brightsec denis-maiorov-brightsec denis-maiorov-brightsec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance CLI Functionality for Monitoring Scan Process Issues
2 participants
@nzvtrk @denis-maiorov-brightsec