feat(scan): print warnings on scan run

src/Commands/RunScan.spec.ts

@@ -67,4 +67,26 @@ describe('RunScan', () => {
       expect(act).toThrowError(SyntaxError);
     });
   });
+
+  describe('serializeWarnings', () => {
+    it('should print warnings correctly', () => {
+      // arrange
+      const input = [
+        {
+          message: 'Notice: Warning 1',
+          code: '1'
+        },
+        {
+          message: 'Notice: Warning 2',
+          code: '2'
+        }
+      ];
+
+      // act
+      const result = RunScan.serializeWarnings(input);
+
+      // assert
+      expect(result).toEqual('Notice: Warning 1\nNotice: Warning 2');
+    });
+  });
 });

src/Commands/RunScan.ts

@@ -7,7 +7,8 @@ import {
   ScanConfig,
   Scans,
   TestType,
-  ATTACK_PARAM_LOCATIONS_DEFAULT
+  ATTACK_PARAM_LOCATIONS_DEFAULT,
+  ScanWarning
 } from '../Scan';
 import { Helpers, logger } from '../Utils';
 import { Arguments, Argv, CommandModule } from 'yargs';
@@ -37,6 +38,10 @@ export class RunScan implements CommandModule {
       });
   }
 
+  public static serializeWarnings(warnings: ScanWarning[]): string {
+    return `${warnings.map((warning) => warning.message).join('\n')}`;
+  }
+
   public builder(argv: Argv): Argv {
     return argv
       .option('token', {
@@ -174,7 +179,7 @@ export class RunScan implements CommandModule {
     try {
       const scanManager: Scans = container.resolve(Scans);
 
-      const scanId: string = await scanManager.create({
+      const { id: scanId, warnings = [] } = await scanManager.create({
         tests: args.test,
         name: args.name,
         module: args.module,
@@ -198,6 +203,10 @@ export class RunScan implements CommandModule {
       // eslint-disable-next-line no-console
       console.log(scanId);
 
+      if (warnings.length) {
+        logger.warn(RunScan.serializeWarnings(warnings));
+      }
+
       process.exit(0);
     } catch (e) {
       logger.error(`Error during "scan:run": ${e.error || e.message}`);

src/Scan/RestScans.spec.ts

@@ -95,7 +95,7 @@ describe('RestScans', () => {
         const result = await restScans.create(scanConfig);
 
         // assert
-        expect(result).toEqual(postResponse.id);
+        expect(result).toEqual({ id: postResponse.id });
         expect(parsedBody).toMatchObject({
           discoveryTypes: expect.arrayContaining<Discovery>([expected])
         });

src/Scan/RestScans.ts

@@ -7,7 +7,8 @@ import {
   SourceType,
   StorageFile,
   SCAN_TESTS_TO_RUN_BY_DEFAULT,
-  ATTACK_PARAM_LOCATIONS_DEFAULT
+  ATTACK_PARAM_LOCATIONS_DEFAULT,
+  ScanCreateResponse
 } from './Scans';
 import { CliInfo } from '../Config';
 import { ProxyFactory } from '../Utils';
@@ -56,15 +57,15 @@ export class RestScans implements Scans {
     });
   }
 
-  public async create(body: ScanConfig): Promise<string> {
+  public async create(body: ScanConfig): Promise<ScanCreateResponse> {
     const scanConfig = await this.prepareScanConfig({ ...body });
 
-    const res = await this.client.post<{ id: string }>(
+    const res = await this.client.post<ScanCreateResponse>(
       '/api/v1/scans',
       scanConfig
     );
 
-    return res.data.id;
+    return res.data;
   }
 
   public async retest(scanId: string): Promise<string> {

src/Scan/Scans.ts

@@ -195,8 +195,18 @@ export interface StorageFile {
   type: SourceType;
 }
 
+export interface ScanWarning {
+  code: string;
+  message: string;
+}
+
+export interface ScanCreateResponse {
+  id: string;
+  warnings: ScanWarning[];
+}
+
 export interface Scans {
-  create(body: ScanConfig): Promise<string>;
+  create(body: ScanConfig): Promise<ScanCreateResponse>;
 
   retest(scanId: string): Promise<string>;