Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(repeater): add tests for repeater command #439

Merged
merged 25 commits into from
Aug 30, 2023
Merged

test(repeater): add tests for repeater command #439

merged 25 commits into from
Aug 30, 2023

Conversation

lsndr
Copy link
Contributor

@lsndr lsndr commented Aug 21, 2023

closes #438

@lsndr lsndr requested a review from derevnjuk August 21, 2023 06:00
@lsndr lsndr self-assigned this Aug 21, 2023
derevnjuk
derevnjuk requested changes Aug 21, 2023
View reviewed changes
.github/workflows/e2e.yml Show resolved Hide resolved
.github/workflows/e2e.yml Outdated Show resolved Hide resolved
.github/workflows/e2e.yml Outdated Show resolved Hide resolved
.github/workflows/e2e.yml Outdated Show resolved Hide resolved
.github/workflows/e2e.yml Outdated Show resolved Hide resolved
.github/workflows/e2e.yml Outdated Show resolved Hide resolved
.github/workflows/e2e.yml Outdated Show resolved Hide resolved
tests/Commands/repeater.spec.ts Outdated Show resolved Hide resolved
tests/Commands/repeater.spec.ts Outdated Show resolved Hide resolved
tests/Commands/repeater.spec.ts Outdated Show resolved Hide resolved
@derevnjuk derevnjuk added Type: technical debt Changes that remove or significantly update old unused code and/or dependencies. Type: tests The issue implements some sort of tests and removed Type: technical debt Changes that remove or significantly update old unused code and/or dependencies. labels Aug 21, 2023
@lsndr lsndr requested a review from derevnjuk August 23, 2023 06:31
derevnjuk
derevnjuk reviewed Aug 24, 2023
View reviewed changes
tests/Commands/repeater.spec.ts Outdated Show resolved Hide resolved
tests/Commands/repeater.spec.ts Outdated Show resolved Hide resolved
@lsndr lsndr requested a review from derevnjuk August 25, 2023 09:30
@lsndr lsndr marked this pull request as draft August 25, 2023 16:16
@lsndr lsndr marked this pull request as ready for review August 29, 2023 06:39
@lsndr
Copy link
Contributor Author

lsndr commented Aug 29, 2023

@derevnjuk here is an example of successful workflow run:

https://github.com/lsndr/bright-cli/actions/runs/6008642855/job/16297225598

derevnjuk
derevnjuk previously approved these changes Aug 29, 2023
View reviewed changes
@derevnjuk derevnjuk changed the base branch from master to next August 29, 2023 09:35
@derevnjuk derevnjuk dismissed their stale review August 29, 2023 09:35

The base branch was changed.

@derevnjuk
Copy link
Member

@lsndr please rebase your branch onto the next

@lsndr lsndr force-pushed the test/add-test-for-repeater branch from caa2ba9 to f9b7489 Compare August 29, 2023 12:30
@lsndr lsndr requested a review from derevnjuk August 29, 2023 13:48
@lsndr lsndr enabled auto-merge (squash) August 30, 2023 12:20
@derevnjuk
Copy link
Member

@lsndr please run tests one more time once #449 is deployed

derevnjuk
derevnjuk previously approved these changes Aug 30, 2023
View reviewed changes
@derevnjuk derevnjuk force-pushed the test/add-test-for-repeater branch from f9b7489 to ac9cd09 Compare August 30, 2023 16:55
@derevnjuk derevnjuk force-pushed the test/add-test-for-repeater branch from 23f37ed to 887e84a Compare August 30, 2023 17:06
@lsndr lsndr merged commit 1a56d02 into next Aug 30, 2023
@lsndr lsndr deleted the test/add-test-for-repeater branch August 30, 2023 17:19
derevnjuk pushed a commit that referenced this pull request Aug 30, 2023
@lsndr @derevnjuk
test(repeater): add tests for repeater command (#439)
3cc3d9d 
closes #438
derevnjuk pushed a commit that referenced this pull request Aug 30, 2023
@lsndr @derevnjuk
test(repeater): add tests for repeater command (#439)
bff6bb2 
closes #438
derevnjuk pushed a commit that referenced this pull request Aug 30, 2023
@lsndr @derevnjuk
test(repeater): add tests for repeater command (#439)
418343e 
closes #438
derevnjuk pushed a commit that referenced this pull request Aug 30, 2023
@lsndr @derevnjuk
test(repeater): add tests for repeater command (#439)
a223a2c 
closes #438
derevnjuk pushed a commit that referenced this pull request Aug 30, 2023
@lsndr @derevnjuk
test(repeater): add tests for repeater command (#439)
f922bd4 
closes #438
@lsndr lsndr mentioned this pull request Sep 18, 2023
Merged
derevnjuk pushed a commit that referenced this pull request Sep 18, 2023
@lsndr
ci(e2e): put environment into run name (#457)
eb8fc1c 
relates-to: #439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derevnjuk derevnjuk derevnjuk approved these changes

Assignees

@lsndr lsndr

Labels
Type: tests The issue implements some sort of tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests for repeater command
2 participants
@lsndr @derevnjuk