refactor: add sentry dsn rotation logic #466
Conversation
lsndr
added
Type: refactoring
| await this.updateConfigFile({ | ||
| ...configFile, | ||
| updatedAt: new Date() | ||
| }); |
There was a problem hiding this comment.
Seems this is redundant. Should we update the configuration as though the rotation was successful?
There was a problem hiding this comment.
I think yes, just because if we don't do that, it will try to perform rotation on every bright-cli call causing at most 1.5 seconds delay.
Since rotation logic is not crucial for the cli for now, I think it's ok in case of failure to repeat it later.
There was a problem hiding this comment.
As you wish. However, I'm still uncertain about how it is supposed to work for long-running processes like the repeater which is intended to work for months.
There was a problem hiding this comment.
Let's have a separate PR for the background rotation
There was a problem hiding this comment.
@lsndr please open a ticket in Jira
relates-to: #458