Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granger causality tutorial notebook #393

Merged
merged 5 commits into from
Jan 6, 2021

Conversation

rjurkus
Copy link
Collaborator

@rjurkus rjurkus commented Dec 23, 2020

I have implemented the GC tutorial notebook focusing on pairwise and conditional causality methods. Please feel free to suggest changes and additions.

@coveralls
Copy link
Collaborator

coveralls commented Dec 23, 2020

Coverage Status

Coverage remained the same at 90.252% when pulling e08556a on INM-6:feature/ar_granger_tutorial into 25d4b1e on NeuralEnsemble:master.

@dizcza
Copy link
Member

dizcza commented Jan 4, 2021

Built tutorial: https://elephant-docs-development.readthedocs.io/en/feature-ar_granger_tutorial/tutorials/granger_causality.html

[minor] There is an issue with the diagram plot (check the built doc), that is circles are (partially or completely) invisible. I'm thinking about whether we should create a folder with such images for additional materials. For now, just fix the diagram.

A description that the direct and indirect non-zero causality values are expected at the end of the tutorial is missing. Probably, you wanted to show that in this case a non-zero value is expected (but the value itself does not matter unless we want to compare it with another causality value).

@dizcza dizcza merged commit 352c04d into NeuralEnsemble:master Jan 6, 2021
@dizcza dizcza deleted the feature/ar_granger_tutorial branch January 6, 2021 08:44
@dizcza dizcza added documentation Indicates a need for improvements or additions to documentation enhancement Editing an existing module, improving something labels Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Indicates a need for improvements or additions to documentation enhancement Editing an existing module, improving something
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants