-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAIN] Fix typos and grammatical errors in GPFA tutorial #587
[MAIN] Fix typos and grammatical errors in GPFA tutorial #587
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kushaangupta ,
thanks for helping to improve the GPFA tutorial.
It seems in the first code cell the following lines were removed unintentionally ?!
See: https://elephant--587.org.readthedocs.build/en/587/tutorials/gpfa.html
def integrated_lorenz(dt, num_steps, x0=0, y0=1, z0=1.05,
sigma=10, rho=28, beta=2.667, tau=1e3):
"""
Parameters
----------
dt :
Integration time step in ms.
The other changes look good to me 💯 .
Hi @Moritz-Alexander-Kern , sorry about that error. I've fixed it now. Also, I also see that the plots in the second half of tutorial, GPFA on Lorentz system haven't been rendered in the uploaded notebook. Should I fix that or are they intentionally not plotted? |
Hi @kushaangupta , |
I pushed the fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, thanks @kushaangupta .
Failing unit tests fixed: #588 |
No description provided.