Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] failing unitests for neo_tools with Neo 0.13.0 #617

Merged
merged 14 commits into from
Mar 22, 2024

Conversation

Moritz-Alexander-Kern
Copy link
Member

@Moritz-Alexander-Kern Moritz-Alexander-Kern commented Feb 7, 2024

Changes

  • fixed failing unitests for neo_tools.
  • fixed failing tests in spike_train_synchrony

Background

With Neo v0.13.0 child lists (such as Segment.spiketrains, Segment.analogsignals, Block.segments, etc.) are now represented by pseudo-list objects that manage the necessary bookkeeping related to child-parent relations transparently.

See also: https://neo.readthedocs.io/en/latest/releases/0.13.0.html

This leads to issues with unit tests in neo_tools, similar to the difficulties encountered with the pseudo list SpikeTrainList introduced with Neo version 0.10.0.

For Neo 0.10.0 this was fixed here: #446

Update

Neo Issue Neo #1405 was fixed. Now it is no longer possible to add the same object to one of the collections (pseudo-lists) twice. Therefore those parts of the unit-tests that creating data in this way have been removed.

@Moritz-Alexander-Kern Moritz-Alexander-Kern added bugfix Fix for an indentified bug. Neo related and removed bugfix Fix for an indentified bug. labels Feb 7, 2024
@Moritz-Alexander-Kern Moritz-Alexander-Kern added this to the v1.1.0 milestone Feb 7, 2024
@pep8speaks
Copy link

pep8speaks commented Feb 7, 2024

Hello @Moritz-Alexander-Kern! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-03-21 14:58:49 UTC

@coveralls
Copy link
Collaborator

coveralls commented Feb 7, 2024

Coverage Status

coverage: 87.895% (-0.3%) from 88.235%
when pulling c59d999 on INM-6:fix/neo_0_13_0
into e2df1b9 on NeuralEnsemble:master.

@Moritz-Alexander-Kern
Copy link
Member Author

Update: You can no longer add the same object twice to a Neo ObjectList: NeuralEnsemble/python-neo#1414 .

So unit tests no longer need to check for duplicates.

Copy link
Collaborator

@kohlerca kohlerca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

Copy link
Member

@mdenker mdenker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I agree that we no longer need the "duplication test", as this is not allowed by Neo any longer.

@mdenker mdenker merged commit 7112f84 into NeuralEnsemble:master Mar 22, 2024
15 of 17 checks passed
@mdenker mdenker deleted the fix/neo_0_13_0 branch March 22, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants