-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] failing unitests for neo_tools with Neo 0.13.0 #617
Conversation
Hello @Moritz-Alexander-Kern! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-03-21 14:58:49 UTC |
Update: You can no longer add the same object twice to a Neo ObjectList: NeuralEnsemble/python-neo#1414 . So unit tests no longer need to check for duplicates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I agree that we no longer need the "duplication test", as this is not allowed by Neo any longer.
Changes
neo_tools
.spike_train_synchrony
Background
With Neo v0.13.0 child lists (such as Segment.spiketrains, Segment.analogsignals, Block.segments, etc.) are now represented by pseudo-list objects that manage the necessary bookkeeping related to child-parent relations transparently.
See also: https://neo.readthedocs.io/en/latest/releases/0.13.0.html
This leads to issues with unit tests in
neo_tools
, similar to the difficulties encountered with the pseudo listSpikeTrainList
introduced with Neo version 0.10.0.For Neo 0.10.0 this was fixed here: #446
Update
Neo Issue Neo #1405 was fixed. Now it is no longer possible to add the same object to one of the collections (pseudo-lists) twice. Therefore those parts of the unit-tests that creating data in this way have been removed.