[Fix] Tests for Neo 0.13.1, add same object to list #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moritz-Alexander-Kern
merged commit 6ce6558
into
NeuralEnsemble:master
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to Neo PR NeuralEnsemble/python-neo#1414 .
With this Neo PR the same object can no longer be added more than once to a given list.
Some tests in Elephant created test data by adding the same object multiple times to a list. Those tests have been fixed without changing the functionality of Elephant functions.
The tests ensuring that functions return only unique objects within a collection, even if the original list contains duplicates, have been revised. This change was made because the test is now conducted in Neo.