Allow standalone app to open multiple files, each in independent windows #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`StandAloneViewer` was replaced by `WindowManager`, which handles spawning a new `MainViewer` each time the Open menu action is used. `WindowManager` also cleans up file locks and deallocates memory when a `MainViewer` is closed. Additionally, when the app is run from the command line without arguments, the `RawNeoOpenDialog` is launched immediately, rather than the user being required to launch it manually with the Open menu action.
|
@samuelgarcia: Do you like this solution to #122? |
|
Hi Jeffrey. Happy new year. |
|
Great, I will merge then. France sounds nice! 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #122.
StandAloneViewerwas replaced byWindowManager, which handles spawning a newMainViewereach time the Open menu action is used.WindowManageralso cleans up file locks and deallocates memory when aMainVieweris closed.Additionally, when the app is run from the command line without arguments, the
RawNeoOpenDialogis launched immediately, rather than the user being required to launch it manually with the Open menu action.Finally, many of the command line interface's help and error messages have been improved.