Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pythonify #5

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Pythonify #5

wants to merge 5 commits into from

Conversation

rmushkin
Copy link

@rmushkin rmushkin commented Dec 5, 2022

Most edits are stylistic, but there are also some fixes in

  1. Type hints for properties
  2. Using nargout argument: in recent versions of oct2py it is nout - handled via try/except
  3. Unconditional calls to octave - replaced with conditional octave/matlab calls
  4. Some mistyped globals.

P. S. While being rather a matter of taste, following some pythonic conventions might be helpful for the further development, so this PR incorporates stylistic changes along with the actual fixes.

@rmushkin rmushkin marked this pull request as draft December 7, 2022 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant