Feat/more morphplots -> exp #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: `pynml.get_next_hex_color` -> `utils.plot.get_next_hex_color`
`pytest` is called in `test-ghactions.sh` already
Required to correctly load the hoc files by NEURON
[skip-ci]
and not in each iteration of the loop CC @pgleeson
…ent groups and overlay them with some data
[ci-skip]
Otherwise plots remain open and consume memory. matplotlib warns: ``` .../pyneuroml/plot/PlotMorphology.py:986: RuntimeWarning: More than 20 figures have been opened. Figures created through the pyplot interface (`matplotlib.pyplot.figure`) are retained until explicitly closed and may consume too much memory. (To control this warning, see the rcParam `figure.max_open_warning`). ```
and add info to inform user that plots are being closed
`q` is used by the `Fly` camera for rolling
[ci skip]
In the future, we may be able to expose these values so users can set them.
[ci skip]
The view has perspective, so the axes and the values they show don't mean anything.
This is more performant than having a Marker object for each sphere. Ideally, we should also use a single Line object to plot all lines in the same way, to improve performance. A TODO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.