Add all missing jnml options #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All missing jnml command-line options were added to pynml. What still needs to be done: - fix the '-neuron' option - touch the help/usage messages a bit
Added the logic that evaluates the command-line options after they have been parsed by argparse. Removed all added debugging/testing code. Improved help/usage messages.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21.
I made the
pynmlcommand-line options as close to thejnmlcommand-line options as possible.The only option that I had troubles porting to
pynmlis-neuron, becauseargparsedoesn't support nested options, so the usage/help message for-neuronis not as good as that for the rest of the options.Also, for the usage/help messages of the added command-line options, I mostly used what was already in
jnmlandpynml. But if there are any changes to be made to these messages, now is probably a good time to do it.