Feat/export swc-Adds function to export SWC graph to a new SWC file #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanjayankur31
requested changes
Jul 11, 2024
pyneuroml/swc/LoadSWC.py
Outdated
| @@ -334,3 +334,22 @@ def load_swc(filename: str) -> SWCGraph: | |||
| tree.add_node(node) | |||
|
|
|||
| return tree | |||
|
|
|||
|
|
|||
| def export_swc(graph: SWCGraph, filename: str) -> None: | |||
There was a problem hiding this comment.
I'd add this to the SWCGraph class as export_to_swc_file. It's still SWC graph related functionality.
tests/swc/.coverage
Outdated
There was a problem hiding this comment.
Remove this file---it shouldn't be checked in. We should add .coverage to .gitignore I guess
| self.output_file = "Case1_exported.swc" | ||
|
|
||
| def test_load_export_compare(self): | ||
| # Load the original file |
There was a problem hiding this comment.
add a one line docstring :)
|
I have worked on the comments, please have a look if time permits. |
|
Sounds good. Ill take a look on Monday.
--
Thanks,
Ankur
(Sent from mobile device)
…On Fri, 12 Jul 2024, 14:26 Aditya Pandey, ***@***.***> wrote:
I have worked on the comments, please have a look if time permits.
—
Reply to this email directly, view it on GitHub
<#404 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAZBL5TA3C4AH2V33KZA4TZL7KPNAVCNFSM6AAAAABKUJJGYGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRVGU4DQNRUGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Looks good. merging this in now. Do remember to pull to update your development and other branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.Adds tests to verify if generated file and input file are similar