Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bars #258

Merged
merged 11 commits into from
Feb 2, 2022
Merged

Progress bars #258

merged 11 commits into from
Feb 2, 2022

Conversation

Div12345
Copy link
Collaborator

Closes #240

Copy link
Member

@sylvchev sylvchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use tqdm class directly instead of using MNE ProgressBar.

moabb/evaluations/evaluations.py Outdated Show resolved Hide resolved
moabb/evaluations/evaluations.py Outdated Show resolved Hide resolved
moabb/evaluations/evaluations.py Outdated Show resolved Hide resolved
moabb/evaluations/evaluations.py Outdated Show resolved Hide resolved
moabb/evaluations/evaluations.py Outdated Show resolved Hide resolved
moabb/evaluations/evaluations.py Outdated Show resolved Hide resolved
Copy link
Member

@sylvchev sylvchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After fixing the m2r error in doc generation, this is good to go!

@sylvchev sylvchev merged commit 3e7fc04 into NeuroTechX:develop Feb 2, 2022
sylvchev pushed a commit that referenced this pull request Feb 22, 2022
* Set download dir test and example (#249)

* Update to dataset_search call in FilterBank Motor Imagery

* Removing completed #fixme

* Removing total_classes argument from dataset_search call in FilterBank MI

This was earlier deprecated in 55f77ae

* set_download_dir test and example

* adding pre-commit modifications

* Update whats_new.rst

* Update examples/changing_download_directory.py

Co-authored-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>

* Update examples/changing_download_directory.py

Co-authored-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>

* Bump pillow from 8.4.0 to 9.0.0 (#253)

Bumps [pillow](https://github.com/python-pillow/Pillow) from 8.4.0 to 9.0.0.
- [Release notes](https://github.com/python-pillow/Pillow/releases)
- [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst)
- [Commits](python-pillow/Pillow@8.4.0...9.0.0)

---
updated-dependencies:
- dependency-name: pillow
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix Schirrmeister2017 error (#255)

* correct event loading error, renaming session and runs

* add whats new

* Removing dependency of Physionet MI download on mne method (#257)

* Update physionet_mi.py

* consistency of runs numbering

* Update whats_new.rst

* f-string edits

Co-authored-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>

* f-string edits

Co-authored-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>

Co-authored-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>

* Correct MAMEM issues (#256)

* switch mamem session to runs, use predictable names

* update docstring in evaluation, for building documentation

* update Lee2017 docstring for correct documentation.

* update whats new

* switch SSVEP example to within session

* correct typo and rebase

* correct typos on examples

* Progress bars (#258)

* Progress bars for downloads using pooch functionality

* Rectification of f-string in PhysionetMI

* Evaluations subject level progress bar

CV test subject level in the case of CrossSubjectEvaluation

* Update poetry.lock

* Update pyproject.toml

* dependencies

* Apply suggestions from code review (mne.utils to tqdm direct)

Co-authored-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>

* Update poetry.lock

* tqdm arg

* Update whats_new.rst

* Update mistune dep

Co-authored-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>

* fix doc url in readme (#262)

* fix doc url in readme

* correct links in the docs

* Schirrmeister2017 High-Gamma Dataset from EDF (#265)

* loading Schirrmeister2017 High-Gamma Dataset from EDF

* remove commented import of requests module

* rename to session_0

* added 13 + 12 subjects speller datasets by huebner (#260)

* added 13 + 12 subjects speller datasets by huebner

* clean up legacy run splitting code

* added use_blocks_as_sessions parameter for data

Co-authored-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>

* added Spot Auditory oddball dataset (#266)

* added Spot Auditory oddball dataset

* replaced usage of deprecated dl.data_path

Co-authored-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>

* Visualize all ERP datasets (#261)

* Visualize all ERP datasets

* * use paradigm.datasets instead of manual list

* more verbose sanity check script

* fix epo data leak + remove title bf

* moved data visualization

added disclaimer regarding data size

Co-authored-by: Sylvain Chevallier <sylvain.chevallier@uvsq.fr>

* update to v0.4.5 (#269)

* update to v0.4.5

* update poetry and requirements

* correct pre-commit error and add code coverage (#271)

Co-authored-by: Divyesh Narayanan <47829318+Div12345@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: robintibor <robintibor@gmail.com>
Co-authored-by: Jan Sosulski <mail@jan-sosulski.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress Bar for Evaluations, Downloads
2 participants