Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix API docs #501

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Fix API docs #501

merged 4 commits into from
Sep 3, 2024

Conversation

CodyCBakerPhD
Copy link
Contributor

@CodyCBakerPhD CodyCBakerPhD commented Sep 3, 2024

fix #500

I am surprised that sphinx-build warns/fails when a target of a section reference - like the best practice links - does not resolve, but doesn't complain about any :py:class: references that fail to link to automodule targets

I tried looking for a way to enforce this but couldn't find a simple one

@CodyCBakerPhD CodyCBakerPhD self-assigned this Sep 3, 2024
@CodyCBakerPhD
Copy link
Contributor Author

Though looks like perhaps newest versions of sphinx might just have some features related to this (this repo is pinned to old one)

When we update to pydata theme we can update sphinx along the way and cross fingers it starts checking that

@CodyCBakerPhD
Copy link
Contributor Author

Yep, looking better: https://nwbinspector--501.org.readthedocs.build/en/501/

@CodyCBakerPhD
Copy link
Contributor Author

@pauladkisson FYI the codecov token updated on 9/3 failed: https://github.com/NeurodataWithoutBorders/nwbinspector/actions/runs/10677233053/job/29592023816?pr=501

I fixed temporarily to get this through: https://github.com/NeurodataWithoutBorders/nwbinspector/actions/runs/10677233053/job/29592455371?pr=501

But you might want to open a 'test' PR on any repos to ensure the workflow completes successfully

@CodyCBakerPhD CodyCBakerPhD linked an issue Sep 3, 2024 that may be closed by this pull request
2 tasks
@bendichter bendichter enabled auto-merge (squash) September 3, 2024 15:45
@bendichter bendichter merged commit a642a3c into dev Sep 3, 2024
35 of 36 checks passed
@bendichter bendichter deleted the fix_api_docs branch September 3, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation]: Auto-generated API is broken [Documentation]: update internal references in docs
2 participants