-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove numpy and h5py restrictions #536
Conversation
The Windows failure is due to a change in Numpy 2.0:
The tests need to be updated. I'll do this next week. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we pin to pynwb<3.0 now since I will need to make updates on the inspector side for the major pynwb release?
Good idea @stephprince . I will do that here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #536 +/- ##
==========================================
+ Coverage 82.71% 86.75% +4.03%
==========================================
Files 47 47
Lines 1510 1510
==========================================
+ Hits 1249 1310 +61
+ Misses 261 200 -61
|
Motivation
numpy was pinned to <2.0 due to incompatibilities in pynwb and hdmf-zarr and maybe other tools. Those should be resolved now.
h5py was pinned to <3.12.0 due to an issue with windows that has been fixed and released.