Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove numpy and h5py restrictions #536

Merged
merged 11 commits into from
Nov 27, 2024
Merged

Remove numpy and h5py restrictions #536

merged 11 commits into from
Nov 27, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Nov 21, 2024

Motivation

numpy was pinned to <2.0 due to incompatibilities in pynwb and hdmf-zarr and maybe other tools. Those should be resolved now.

h5py was pinned to <3.12.0 due to an issue with windows that has been fixed and released.

@rly
Copy link
Contributor Author

rly commented Nov 22, 2024

The Windows failure is due to a change in Numpy 2.0:

The default integer type on Windows is now int64 rather than int32, matching the behavior on other platforms

The tests need to be updated. I'll do this next week.

@rly rly requested a review from stephprince November 26, 2024 02:43
Copy link
Contributor

@stephprince stephprince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we pin to pynwb<3.0 now since I will need to make updates on the inspector side for the major pynwb release?

@rly
Copy link
Contributor Author

rly commented Nov 27, 2024

Good idea @stephprince . I will do that here.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.75%. Comparing base (165c727) to head (225f830).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #536      +/-   ##
==========================================
+ Coverage   82.71%   86.75%   +4.03%     
==========================================
  Files          47       47              
  Lines        1510     1510              
==========================================
+ Hits         1249     1310      +61     
+ Misses        261      200      -61     
Files with missing lines Coverage Δ
src/nwbinspector/checks/_tables.py 97.45% <100.00%> (ø)

... and 5 files with indirect coverage changes

@rly rly merged commit 52b1707 into dev Nov 27, 2024
40 checks passed
@rly rly deleted the rly-patch-1 branch November 27, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants