Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompassDirection.spatialSeries.data.unit problem #1315

Closed
bendichter opened this issue Nov 10, 2020 · 2 comments · Fixed by #1316
Closed

CompassDirection.spatialSeries.data.unit problem #1315

bendichter opened this issue Nov 10, 2020 · 2 comments · Fixed by #1316
Assignees
Labels
category: bug errors in the code or code behavior

Comments

@bendichter
Copy link
Contributor

bendichter commented Nov 10, 2020

CompassDirection is a MultiContainerInterface that takes SpatialSeries objects, and specifies that these objects should have units "degrees" or "radians". SpatialSeries in the nwb schema provides "meters" as a default value for data.units, but pynwb's implementation hard-codes that the units must be meters. To accommodate CompassDirection and to be consistent with the schema, the units arg of SpatialSeries should be a default value of "meters" but should be changeable.

cc @weiglszonja

@bendichter bendichter added the category: bug errors in the code or code behavior label Nov 10, 2020
@bendichter
Copy link
Contributor Author

@weiglszonja, would you be able to create a PR for this on this repo?

@weiglszonja
Copy link
Collaborator

@bendichter thanks for creating this issue. Yes, I will create one 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: bug errors in the code or code behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants