Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unmapped attributes #1105

Merged
merged 3 commits into from
Nov 12, 2019
Merged

Handle unmapped attributes #1105

merged 3 commits into from
Nov 12, 2019

Conversation

rly
Copy link
Contributor

@rly rly commented Nov 12, 2019

This PR fixes errors that will occur when hdmf-dev/hdmf#196 is merged.

  • Make explicit that the NWBFile/general/intracellular_ephys/filtering dataset does not map to any attribute in the NWBFile class.
  • Make explicit that the TimeSeries/sync group does not map to any attribute in the TimeSeries class.
  • Fix a test where a DataFrame had the column name "description". Since "description" is an attribute of DynamicTable, the name "description" is not allowed for new column names (see Raise error if expected attribute does not exist on a Container hdmf-dev/hdmf#196)

@rly rly requested review from ajtritt and oruebel November 12, 2019 22:35
@codecov
Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #1105 into dev will increase coverage by 0.11%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #1105      +/-   ##
=========================================
+ Coverage   67.19%   67.3%   +0.11%     
=========================================
  Files          38      38              
  Lines        2274    2288      +14     
  Branches      394     394              
=========================================
+ Hits         1528    1540      +12     
- Misses        677     679       +2     
  Partials       69      69
Impacted Files Coverage Δ
src/pynwb/io/base.py 25.92% <0%> (-1%) ⬇️
src/pynwb/io/file.py 77.94% <100%> (+2.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c44561...b264803. Read the comment docs.

@rly rly merged commit e1080cd into dev Nov 12, 2019
@rly rly deleted the fix/missing_attrs branch November 12, 2019 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants