Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for device description and manufacturer #1135

Merged
merged 2 commits into from
Jan 8, 2020
Merged

Conversation

rly
Copy link
Contributor

@rly rly commented Jan 8, 2020

@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

❗ No coverage uploaded for pull request base (dev@e84d2a3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev   #1135   +/-   ##
=====================================
  Coverage       ?   67.5%           
=====================================
  Files          ?      38           
  Lines          ?    2302           
  Branches       ?     397           
=====================================
  Hits           ?    1554           
  Misses         ?     679           
  Partials       ?      69

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e84d2a3...b01db5c. Read the comment docs.

@rly rly merged commit 3b1efb5 into dev Jan 8, 2020
@rly rly deleted the enh/support_device branch January 8, 2020 21:29
@lvsltz
Copy link

lvsltz commented Feb 27, 2020

What is the right combination of versions to have these new attributes? I am not able to have them written to nwb.

@t-b
Copy link
Collaborator

t-b commented Feb 27, 2020

@lvsltz Did you try #1146?

@lvsltz
Copy link

lvsltz commented Feb 27, 2020

Oh, I see. Thanks!

@lvsltz
Copy link

lvsltz commented Mar 18, 2020

This doesn't seem to work with pynwb==1.3.0 and hdmf==1.6.1.

@rly
Copy link
Contributor Author

rly commented Mar 18, 2020

Thanks @lvsltz . You're correct - the new fields cannot be set. I created a new ticket here: #1208

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants