Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop py36 support, update CI, reqs, tests for rc/2.0.0 #1377

Merged
merged 9 commits into from
Jul 7, 2021
Merged

Conversation

rly
Copy link
Contributor

@rly rly commented Jul 7, 2021

  • Drop py36 support, update CI and requirements
  • Add py39 support
  • Fix numpy deprecation errors in tests
  • Fix validation test errors
  • Fix dtype conversion and deprecation warnings in tests
  • Fix backward compatibility test warnings

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly changed the title Drop py36 support, update CI, reqs, tests Drop py36 support, update CI, reqs, tests for rc/2.0.0 Jul 7, 2021
@rly rly requested a review from oruebel July 7, 2021 19:47
@rly
Copy link
Contributor Author

rly commented Jul 7, 2021

gallery39 tests fail because the allensdk does not yet support python 3.9, so CI for PR will run gallery38 tests instead of gallery39 tests for now

Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rly
Copy link
Contributor Author

rly commented Jul 7, 2021

The gallery38 error is due to an incompatibility between allensdk and h5py 3 (Dataset.value is deprecated). I believe this will be addressed soon as they work on adding h5py 3 and py39 support after pynwb/hdmf adds it.

@rly rly merged commit 16cae9d into rc/2.0.0 Jul 7, 2021
@rly rly deleted the update_ci_reqs2 branch July 7, 2021 20:12
rly added a commit that referenced this pull request Aug 10, 2021
Drop py36 support, update CI, reqs, tests for rc/2.0.0 (#1377)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants