More loosely select dependendency versions #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kalebu
approved these changes
Feb 3, 2023
|
Make sense, Thanks for contributing @mscansian Merging this into the main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this project is very strict regarding the dependency version it uses. This means that it doesn't work nicely with project that require version freezing, cause it will generate conflict if it has the same dependency in the project but a different version for some reason. This is likely to happen a lot with the
requestspackage since it's widely used or even another project using flask.Version freezing should be reserved to the main project, not an external lib, unless it actually requires a specific version. As far as I can see there's no reason to use the exact specific version, so I'm proposing to change it to a more loose version requirement.