Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various dependencies & setup fixes #78

Merged
merged 6 commits into from
Apr 8, 2023
Merged

Various dependencies & setup fixes #78

merged 6 commits into from
Apr 8, 2023

Conversation

filipporomani
Copy link
Contributor

  • Removed unused dependencies: Flask was inserted into setup.py, even if it's not used by heyoo. Flask is used by Docker, but should not be inserted in the setup.py file.
  • Added missing dependencies: colorama and typing. They were not in the setup.py file, and this could result in errors while running.
  • Fixed description: now the setup.py file uses the README file as long description. This makes everything easier, as the description is updated on a new release.
  • Grammar fix in setup.py.
  • Removed useless temp files.

@filipporomani filipporomani deleted the patch-1 branch April 7, 2023 20:47
@Kalebu
Copy link
Contributor

Kalebu commented Apr 8, 2023

Hey @filipporomani

May I ask Why did you close this patch? I think I am pretty useful indeed

@filipporomani filipporomani restored the patch-1 branch April 8, 2023 10:27
@filipporomani
Copy link
Contributor Author

I actually can't remember this. Good question. Sorry for the issue. I am reopening this rn.

Also: I actually made a fork of the repo and made many changes, is it ok if I create some PRs with the changes I made in the other repo?

@filipporomani filipporomani reopened this Apr 8, 2023
Kalebu
Kalebu approved these changes Apr 8, 2023
View reviewed changes
Copy link
Contributor

@Kalebu Kalebu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Nice cleanup @filipporomani

@Kalebu Kalebu merged commit a6d5c3a into Neurotech-HQ:main Apr 8, 2023
@filipporomani
Copy link
Contributor Author

Thanks! Glad to help!

@filipporomani filipporomani deleted the patch-1 branch April 8, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kalebu Kalebu Kalebu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipporomani @Kalebu