Log warnings on missing images and GL functions #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, always happy to see some Neverball hacking. I'd like to merge the missing newline fix. Can you make a new PR with that change only? Cheers. |
|
Sure. Will do. |
|
I think warning about missing files is important to diagnose issues like #170 instead of silently failing. Can't remember why I was holding off on merging this. |
|
Yeah, definitely. I'll merge this as time permits. |
|
I get a few warnings about |
|
Any chance on getting this merged soon? A couple of unnecessary warnings is better than no warnings :) |
parasti
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've come across some level packs (such as penma's that have missing textures that appear white in-game, so this is to help diagnose that.
Most maps seem to reference this material called "default", which I assume is supposed to be this, and that triggers lots of warnings from mapc when building the maps.
https://github.com/Neverball/neverball/blob/master/share/mtrl.c#L51