🚑️ [배포 후 긴급 수정] : 뉴스 모니터링 시스템의 Count 문제 해결 + 핫토픽의 뉴스 더보기 데이터의 최신화

[passionryu]

Summary by CodeRabbit

• 버그 수정

  • 키워드 검색 시 뉴스 기사 결과가 전날(00:00~24:00)에 발행된 기사로 제한됩니다.

• 신규 기능

  • 배치 작업 완료 여부를 Redis를 통해 확인하고 표시할 수 있는 기능이 추가되었습니다.

• 리팩터링

  • 뉴스 모니터링 배치 실행 로직이 개선되어, 일별·섹션별로 Redis를 활용한 실행 횟수 제한 및 중복 실행 방지가 적용되었습니다.
  • 자정(00시)에는 모니터링이 실행되지 않도록 조건이 추가되었습니다.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

검색 서비스와 뉴스 모니터링 서비스의 배치 관리 로직이 개선되었습니다. 뉴스 검색은 어제 날짜로 제한하는 필터가 추가되었고, 모니터링 서비스는 Redis를 활용한 일별/섹션별 배치 실행 관리 및 중복 실행 방지 로직이 도입되었습니다. 관련 메서드가 추가 및 리팩토링되었습니다.

Changes

파일/경로	변경 요약
.../News_Deliver/Global/News/ElasticSearch/service/NewsEsService.java	searchByKeyword 메서드가 어제 날짜로 제한하는 필터를 추가하여 수정됨. 기존 버전은 주석 처리 및 deprecated 표기.
.../News_Deliver/Global/NewsMonitoring/Service/IntermediateBatchRedisService.java	Redis 기반 배치 완료 체크/마킹용 isBatchAlreadyDone, markBatchDone 메서드 2개 신규 추가.
.../News_Deliver/Global/NewsMonitoring/Service/NewsMonitoringService.java	monitoring 메서드 리팩토링: 일별/섹션별 Redis 키로 배치 실행 관리, 중복 실행 방지, 로그 추가. 기존 로직 주석 처리.

Sequence Diagram(s)

sequenceDiagram
    participant Scheduler
    participant NewsMonitoringService
    participant IntermediateBatchRedisService
    participant Redis

    Scheduler->>NewsMonitoringService: monitoring()
    NewsMonitoringService->>IntermediateBatchRedisService: isBatchAlreadyDone(batchDoneKey)
    IntermediateBatchRedisService->>Redis: EXISTS batchDoneKey
    Redis-->>IntermediateBatchRedisService: true/false
    IntermediateBatchRedisService-->>NewsMonitoringService: true/false

    alt 배치 미실행 시
        NewsMonitoringService->>NewsMonitoringService: runNewsBatch()
        NewsMonitoringService->>IntermediateBatchRedisService: markBatchDone(batchDoneKey)
        IntermediateBatchRedisService->>Redis: SET batchDoneKey "done" EX 12h
    else 이미 실행됨
        NewsMonitoringService->>NewsMonitoringService: skip
    end

Loading

sequenceDiagram
    participant User
    participant NewsEsService
    participant ElasticSearch

    User->>NewsEsService: searchByKeyword(keyword, size)
    NewsEsService->>ElasticSearch: 검색 (combinedTokens 일치 + publishedAt 어제 날짜 필터)
    ElasticSearch-->>NewsEsService: 결과 반환
    NewsEsService-->>User: 결과 반환

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~18 minutes

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c446bf and 761c589.

📒 Files selected for processing (3)

• SpringBoot/src/main/java/Baemin/News_Deliver/Global/News/ElasticSearch/service/NewsEsService.java (2 hunks)
• SpringBoot/src/main/java/Baemin/News_Deliver/Global/NewsMonitoring/Service/IntermediateBatchRedisService.java (1 hunks)
• SpringBoot/src/main/java/Baemin/News_Deliver/Global/NewsMonitoring/Service/NewsMonitoringService.java (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch hotfix/1

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.