Added pattern support tonumbers:list
#140
Conversation
|
What has this been replaced with? |
|
@cbetta - Thanks for the comment. I'd completely missed that in doing this we lose the |
|
Probably a good idea to list what something fixes when it's marked as a FIX ;) |
|
Also what's up with the commit history here? It's removing one feature with 6 commits, and yet the README not the CHANGELOG is updated. |
src/bin.js
Outdated
| .command('number:list', null, { noHelp: true }) | ||
| .alias('numbers') | ||
| .alias('numbers:list') |
There was a problem hiding this comment.
This doesn't work. You can't double alias (at least you couldn't last year)
There was a problem hiding this comment.
number:buy seems to do the same thing and has 2 aliases.
There was a problem hiding this comment.
@AlexLakatos that might be a mistake. Can you test this please?
There was a problem hiding this comment.
and testing it out on the CLI, it seems the last alias is the only one considered, and all others get to undefined, prompting help to be listed.
There was a problem hiding this comment.
That seems to confirm what I remembered of it. We should probably fix the number:buy one
|
@AlexLakatos so the reason so much code seems duplicate in If you found a solution to this we should probably deduplicate most secondary aliases. I added a lot of aliases to help remove the need to remember if every command is singular (number) or plural (numbers). |
|
@AlexLakatos ok to close this issue and open a ticket for the |
|
@cbetta not really. I'll just change scope to re-add |
|
@AlexLakatos can we fix the commit history for this branch? It seems a bit messed up. Probably based on wrong base commit |
AlexLakatos
changed the title
numbers:listnumbers:list
|
@cbetta wouldn't that be fixed anyway with a squash and merge? |
|
@AlexLakatos as long as we do a squash ;) |
No description provided.