-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nexmo Server SDK V5 Support #6
base: main
Are you sure you want to change the base?
Conversation
I'm working on a blog post around piping Conversation API events into Kafka + Snowflake for processing. I noticed that the starter hasn't been updated in a while, so I took the opportunity to migrate from v4 to v5 of the Nexmo Server SDK. |
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 25 25
===========================================
Files 2 2
Lines 33 33
Branches 4 4
===========================================
Hits 33 33
Continue to review full report at Codecov.
|
Any chance at getting this reviewed/released sometime soonish? Thanks! |
It's me again. It looks like the server SDK is now on 5.5.0. I can update to target that. |
Hi @cr0wst sorry about the late response. We were so tied up in the rebrand that I didn't notice your comments. Yes, updating to 5.5.0 would be very helpful. Also, can you switch it to the |
Sure. I'll swap that over here shortly. If you need any help with renaming the package for this project too, just let me know! :) |
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 25 25
===========================================
Files 2 2
Lines 33 33
Branches 4 4
===========================================
Hits 33 33
Continue to review full report at Codecov.
|
Updated the references to the old Nexmo address. I didn't update some of the properties because I didn't know how far you wanted to take it. |
This PR adds support for the 5.2.1 server SDK as well as updates the targeted spring-boot version.