Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nexmo Server SDK V5 Support #6

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

cr0wst
Copy link

@cr0wst cr0wst commented Jul 25, 2020

This PR adds support for the 5.2.1 server SDK as well as updates the targeted spring-boot version.

@cr0wst
Copy link
Author

cr0wst commented Jul 25, 2020

I'm working on a blog post around piping Conversation API events into Kafka + Snowflake for processing. I noticed that the starter hasn't been updated in a while, so I took the opportunity to migrate from v4 to v5 of the Nexmo Server SDK.

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2020

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              master        #6   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        25        25           
===========================================
  Files              2         2           
  Lines             33        33           
  Branches           4         4           
===========================================
  Hits              33        33           
Impacted Files Coverage Δ Complexity Δ
...kotlin/com/nexmo/starter/NexmoAutoConfiguration.kt 100.00% <ø> (ø) 25.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7196fa...2c08f7c. Read the comment docs.

@cr0wst
Copy link
Author

cr0wst commented Aug 17, 2020

Any chance at getting this reviewed/released sometime soonish?

Thanks!

@cr0wst
Copy link
Author

cr0wst commented Sep 8, 2020

It's me again. It looks like the server SDK is now on 5.5.0. I can update to target that.

@yallen011
Copy link
Contributor

Hi @cr0wst sorry about the late response. We were so tied up in the rebrand that I didn't notice your comments. Yes, updating to 5.5.0 would be very helpful. Also, can you switch it to the com.vonage.client:5.5.0 dependency instead since we are in the process of moving everything over to use that dependency since the rebrand. They have the exact same functionality, the code that use the vonage namespace instead now.

@cr0wst
Copy link
Author

cr0wst commented Oct 16, 2020

Sure. I'll swap that over here shortly. If you need any help with renaming the package for this project too, just let me know! :)

@codecov-io
Copy link

codecov-io commented Oct 27, 2020

Codecov Report

Merging #6 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master        #6   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        25        25           
===========================================
  Files              2         2           
  Lines             33        33           
  Branches           4         4           
===========================================
  Hits              33        33           
Impacted Files Coverage Δ Complexity Δ
...kotlin/com/nexmo/starter/NexmoAutoConfiguration.kt 100.00% <100.00%> (ø) 25.00 <11.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6247b4c...9c81bc0. Read the comment docs.

@cr0wst
Copy link
Author

cr0wst commented Oct 27, 2020

Updated the references to the old Nexmo address. I didn't update some of the properties because I didn't know how far you wanted to take it.

@mheap mheap changed the base branch from master to main February 2, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants