Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FindMy Flipper Battery Status Refactor, Unify State Sync #100

Merged
merged 7 commits into from
Apr 19, 2024
Merged

FindMy Flipper Battery Status Refactor, Unify State Sync #100

merged 7 commits into from
Apr 19, 2024

Conversation

MatthewKuKanich
Copy link
Member

@MatthewKuKanich MatthewKuKanich commented Apr 19, 2024 •
edited by Willy-JL
Loading

What's new

  • [FindMy Flipper Battery Status Refactor, Unify State Sync]

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

Willy-JL
Willy-JL requested changes Apr 19, 2024
View reviewed changes
Copy link
Member

@Willy-JL Willy-JL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nitpicks, you know me )

applications/system/findmy/findmy_state.c Outdated Show resolved Hide resolved
applications/system/findmy/findmy_i.h Outdated Show resolved Hide resolved
Willy-JL
Willy-JL approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@Willy-JL Willy-JL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for bearing with me )

@Willy-JL Willy-JL merged commit c4c1870 into dev Apr 19, 2024
3 checks passed
@Willy-JL Willy-JL deleted the findmy-battery branch April 19, 2024 01:21
@Willy-JL Willy-JL added the feature New feature or request label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Willy-JL Willy-JL Willy-JL approved these changes

@Sil333033 Sil333033 Awaiting requested review from Sil333033 Sil333033 is a code owner

@HaxSam HaxSam Awaiting requested review from HaxSam HaxSam is a code owner

Assignees

@MatthewKuKanich MatthewKuKanich

Labels
feature New feature or request
Projects
Momentum Progress Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthewKuKanich @Willy-JL