Archive: Favorite .mag files #110
Conversation
zacharyweiss
requested review from
Willy-JL,
Sil333033,
HaxSam and
MatthewKuKanich
as code owners
|
Nix this if it seems out-of-scope, I can imagine that adding each EXT fap to have favoritable files could become unwieldy to maintain; don't want to set the wrong precedent by accident. |
|
Do I need to manually run the build with f18 targets to configure those symbols properly? Haven't made FW PRs that cause a change to the API ver before |
| @@ -34,6 +34,8 @@ const char* archive_get_flipper_app_name(ArchiveFileTypeEnum file_type) { | |||
| return "Bad KB"; | |||
| case ArchiveFileTypeWAV: | |||
| return EXT_PATH("apps/Media/wav_player.fap"); | |||
| case ArchiveFileTypeMag: | |||
| return EXT_PATH("apps/GPIO/magspoof.fap"); | |||
There was a problem hiding this comment.
Also reminds me about the wav player, for the previous files we added support for, we moved the applications to the firmware repository. The idea was that if one day we were to make a build without apps included, these that have file associations would be included anyway. But now I'm not so sure, on both of these things. I'm not sure if we'd actually ever have a build without apps, sounds like unnecessary complexity and confusion, and would need some rework of the webupdater. And even if we do decide to do that, I'm not sure that including the apps regardless just because they have file associations, would make sense. Could just be that if you did install one without apps, then it would give an error for the app missing...
Nothing to change here, just a discussion we'll have to go over with the team
There was a problem hiding this comment.
Hm, I wonder if we could do something clever like implement an optional ArchiveSupportedFaps interface, like NFC does with NfcSupportedCardsPlugin, where one can populate the relevant stuct fields (just file icon and fap path?) and then the list gets auto-built onload of the archive. Probably out of scope, but would eliminate maintenance edits like this, and handle the above edge case you're mentioning nicely. Would leave it up to FAP authors to implement or not, and I don't think it'd cause conflicts across FWs (or if so, easy enough to just wrap in an ifdef like the other FW-specific features)
|
I'll get the app updates merged in and update the submodule in this Pr Also no, we don't deal with f18 (yet) so we leave it fully untouched to avoid unnecessary merge conflicts |
|
not sure why the build is failing tho |
|
ah its because of my changes to fbt_options.py, doesnt seem to play well here for some reason, probably due to how the repo is cloned on PRs |
What's new
.magfiles (for use with magspoof commit >= 3ad981c)mag_card_10px.pngtoarchive;I_mag_card_10pxto symbolsFor the reviewer