Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrared: Correct Samsung.ir CH+ command #156

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

skyhawkillusions
Copy link
Contributor

@skyhawkillusions skyhawkillusions commented Jul 7, 2024

What's new

  • CH+ and CH- commands have same command currently
  • CH+ is supposed to be 12 00 00 00 instead of 10 00 00 00
  • Verified by comparing other files on UberGuidoZ repo and by checking own remotes

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

CH+ command is supposed to be 12 00 00 00 not 10 00 00 00
@Willy-JL Willy-JL added the bugfix Something isn't working label Jul 9, 2024
@Willy-JL Willy-JL changed the title Correct Samsung.ir Infrared: Correct Samsung.ir CH+ command Jul 9, 2024
Copy link
Member

@Willy-JL Willy-JL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Willy-JL Willy-JL merged commit 4460142 into Next-Flip:dev Jul 9, 2024
2 checks passed
@skyhawkillusions skyhawkillusions deleted the patch-1 branch July 10, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants