Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrared: Added missing Koro Box entry to TV universal remote #159

Merged
merged 10 commits into from
Jul 11, 2024

Conversation

skyhawkillusions
Copy link
Contributor

@skyhawkillusions skyhawkillusions commented Jul 10, 2024

What's new

This is a combination of multiple changes that modified the databases to keep them up to date:

  • tv.ir has been updated based on a version of the file I found on an RM SD card with Koro Box entry which is in OFW's tv.ir
  • audio.ir has been updated based on a version of the file I found on an RM SD card
  • NFC key dictionary has been updated based on the latest RRG file

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

I copied this off a RogueMaster RM0329-0318-42018 SD card, IDK if these changes were in previous Mntm but subsequently discarded
Found these on my RM0329 SD card, I am not sure if these two buttons were accidentally discarded or if they don't actually work
I compared the nfc key dictionaries between the current mf_classic_dict.nfc and the one constantly being updated by the RFID Research Group, and, while the MNTM file is much larger, there are keys updated by the RRG that are NOT in the current build.

1. I downloaded both dict files and deleted all lines that did not start with 0-9 & A-F, converted case to uppercase, alphabetized them, then compared the lists using WinMerge. 
2. Generating a patch via WinMerge, I isolated the keys that were in the RRG dict and not in the MNTM dict.
3. I individually cross-referenced the keys that I got to obtain the categories they belong to in the RRG dict. Having categorized all these, I have formatted them and uploaded them to the repository accordingly.
@Willy-JL Willy-JL changed the title Update .ir and .nfc assets Update .ir TV assets Jul 11, 2024
@Willy-JL
Copy link
Member

we talked on discord, i will summarize here for transaprency. we have our mfc dict organized in a way that simplifies updating, i have gone ahead and updated it myself, thanks for the reminder to do so.

as for IR assets, most seemed to be duplicates (hence why i had already removed them in the past when merging from upstream), but Koro box is not. seems like this is all that remains from this PR.

regardless, thank you and i appreciate the effort :D

@Willy-JL Willy-JL changed the title Update .ir TV assets Infrared: Added missing Koro Box entry to TV universal remote Jul 11, 2024
@Willy-JL Willy-JL added the enhancement New enhancement or request label Jul 11, 2024
@Willy-JL Willy-JL merged commit 60832d6 into Next-Flip:dev Jul 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New enhancement or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants