Infrared: Added missing Koro Box entry to TV universal remote #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I copied this off a RogueMaster RM0329-0318-42018 SD card, IDK if these changes were in previous Mntm but subsequently discarded
Found these on my RM0329 SD card, I am not sure if these two buttons were accidentally discarded or if they don't actually work
I compared the nfc key dictionaries between the current mf_classic_dict.nfc and the one constantly being updated by the RFID Research Group, and, while the MNTM file is much larger, there are keys updated by the RRG that are NOT in the current build. 1. I downloaded both dict files and deleted all lines that did not start with 0-9 & A-F, converted case to uppercase, alphabetized them, then compared the lists using WinMerge. 2. Generating a patch via WinMerge, I isolated the keys that were in the RRG dict and not in the MNTM dict. 3. I individually cross-referenced the keys that I got to obtain the categories they belong to in the RRG dict. Having categorized all these, I have formatted them and uploaded them to the repository accordingly.
Update audio.ir
Update mf_classic_dict.nfc
skyhawkillusions
requested review from
Willy-JL,
Sil333033,
HaxSam and
MatthewKuKanich
as code owners
|
we talked on discord, i will summarize here for transaprency. we have our mfc dict organized in a way that simplifies updating, i have gone ahead and updated it myself, thanks for the reminder to do so. as for IR assets, most seemed to be duplicates (hence why i had already removed them in the past when merging from upstream), but Koro box is not. seems like this is all that remains from this PR. regardless, thank you and i appreciate the effort :D |
Willy-JL
changed the title
Willy-JL
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
This is a combination of multiple changes that modified the databases to keep them up to date:
based on a version of the file I found on an RM SD cardwith Koro Box entry which is in OFW's tv.iraudio.ir has been updated based on a version of the file I found on an RM SD cardNFC key dictionary has been updated based on the latest RRG fileFor the reviewer