Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main Menu: Unload when opening apps #161

Merged
merged 22 commits into from
Jul 18, 2024
Merged

Main Menu: Unload when opening apps #161

merged 22 commits into from
Jul 18, 2024

Conversation

Willy-JL
Copy link
Member

@Willy-JL Willy-JL commented Jul 15, 2024 •
edited
Loading

What's new

  • Unload main menu and app list when opening apps
  • Saves some RAM (about 6-7kb)
  • Needs more testing

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

@Willy-JL Willy-JL added the enhancement New enhancement or request label Jul 15, 2024
@Willy-JL Willy-JL self-assigned this Jul 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 16, 2024 •
edited
Loading

Compiled f7 firmware for commit a6b10f41:

@Willy-JL Willy-JL mentioned this pull request Jul 16, 2024
Open
@Willy-JL Willy-JL linked an issue Jul 17, 2024 that may be closed by this pull request
NFC: OOM Crash #144
Open
@Willy-JL Willy-JL marked this pull request as ready for review July 18, 2024 02:02
@Willy-JL Willy-JL merged commit b675443 into dev Jul 18, 2024
5 checks passed
@Willy-JL Willy-JL deleted the unload-main-menu branch July 18, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sil333033 Sil333033 Awaiting requested review from Sil333033 Sil333033 is a code owner

@HaxSam HaxSam Awaiting requested review from HaxSam HaxSam is a code owner

@MatthewKuKanich MatthewKuKanich Awaiting requested review from MatthewKuKanich MatthewKuKanich is a code owner

Assignees

@Willy-JL Willy-JL

Labels
enhancement New enhancement or request
Projects
Momentum Progress Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NFC: OOM Crash
1 participant
@Willy-JL