Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infrared: Remove duplicates from LED universal remote #165

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Infrared: Remove duplicates from LED universal remote #165

merged 2 commits into from
Jul 18, 2024

Conversation

Wemmy0
Copy link
Contributor

@Wemmy0 Wemmy0 commented Jul 17, 2024 •
edited by Willy-JL
Loading

Remove duplicates

What's new

Removed some duplicates from led.ir universal remote

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

@Wemmy0
Update led.ir
e27a9ac 
Remove duplicates
@Wemmy0
Copy link
Contributor Author

Wemmy0 commented Jul 17, 2024

Errors, opening when fixed

@Wemmy0 Wemmy0 closed this Jul 17, 2024
@Wemmy0
Update led.ir
8af1a86 
Fix led.ir
@Wemmy0
Copy link
Contributor Author

Wemmy0 commented Jul 17, 2024

Never mind, there where no errors. Just the compare tool acting weird

@Wemmy0 Wemmy0 reopened this Jul 17, 2024
@Willy-JL Willy-JL changed the title Update led.ir Infrared: Remove duplicates from LED universal remote Jul 18, 2024
@Willy-JL Willy-JL added the bugfix Something isn't working label Jul 18, 2024
Willy-JL
Willy-JL approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@Willy-JL Willy-JL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Willy-JL Willy-JL merged commit 33d940e into Next-Flip:dev Jul 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Willy-JL Willy-JL Willy-JL approved these changes

@Sil333033 Sil333033 Awaiting requested review from Sil333033 Sil333033 is a code owner

@HaxSam HaxSam Awaiting requested review from HaxSam HaxSam is a code owner

@MatthewKuKanich MatthewKuKanich Awaiting requested review from MatthewKuKanich MatthewKuKanich is a code owner

Assignees

@Wemmy0 Wemmy0

Labels
bugfix Something isn't working
Projects
Momentum Progress Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wemmy0 @Willy-JL