Favorite-able WAV files #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namely just for the sake of favorite-ing the cart lock/unlock. Requires changes to WAV player ext fap, as to be PR'd from the Momentum-Apps repo.
zacharyweiss
requested review from
Willy-JL,
Sil333033,
HaxSam and
MatthewKuKanich
as code owners
that sounds like the best course of action, yes |
Willy-JL
approved these changes
Apr 17, 2024
|
Great! PR'd the apps repo; once that's merged will push another commit here if needed for handling the commit ID bookkeeping |
|
about the favorite timeout, that should be mostly irrelevant. the idea for it is to quit favorite files after a configured amount of time, makes sense for things like subghz files and nfc and rfid, not so much for wav files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Primarily just wanted this feature for the sake of favorite-ing the cart lock/unlock WAVs.
archiveto recognize.wavfiles as openable bywav_player; as such enables "favorite" menu itemwav_playerto allow "direct launching" from a file, rather than requiring a file browser dialog to select the file after starting the FAP.The latter is messy / very quickly done as proof-of-concept. Doesn't yet impl the "favorite timeout" feature (have yet to use this myself so not actually sure what it does). Aside from that, anything missing that needs implementing to finalize this as a feature?
Given the required changes across both this repo and the submoduled apps repo, what's the best form for PR here? Shall I open a separate PR on the apps repo and reference the two?
For the reviewer