-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sync add to folder
changes to server
#45
Conversation
Reviewer's Guide by SourceryThe pull request fixes a bug where changes made when adding a chat to a folder were not being synced to the server. This was caused by a bad merge in version 11.7.0. The fix ensures that all relevant filter data is included when saving changes to the server. Class diagram showing filter-related changesclassDiagram
class Filter {
+List~Long~ alwaysShow
+List~Long~ neverShow
+List~Long~ pinnedDialogs
+String name
+String emoticon
+int flags
+int color
+String entities
+boolean title_noanimate
}
class FilterCreateActivity {
+saveFilterToServer(Filter filter, int flags, String emoticon, String name, String entities, boolean title_noanimate, int color, List alwaysShow, List neverShow, List pinnedDialogs, boolean atBegin, boolean newFilter, boolean async, boolean force, boolean progress, BaseFragment fragment, Runnable onFinish)
}
note for Filter "Added entities and title_noanimate fields for server sync"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @risin42 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Okay, let me add some details. Steps to Reproduce:
This can be reproduced on any build after 11.7.0(1204). |
Seems good |
This fixes an issue where "Add to Folder" wasn't syncing to the server, caused by a bad merge in version 11.7.0.
Summary by Sourcery
Bug Fixes: