Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync add to folder changes to server #45

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

risin42
Copy link
Contributor

@risin42 risin42 commented Feb 3, 2025

This fixes an issue where "Add to Folder" wasn't syncing to the server, caused by a bad merge in version 11.7.0.

Summary by Sourcery

Bug Fixes:

  • Fix an issue where changes made using "Add to Folder" were not being saved to the server.

Copy link

sourcery-ai bot commented Feb 3, 2025

Reviewer's Guide by Sourcery

The pull request fixes a bug where changes made when adding a chat to a folder were not being synced to the server. This was caused by a bad merge in version 11.7.0. The fix ensures that all relevant filter data is included when saving changes to the server.

Class diagram showing filter-related changes

classDiagram
    class Filter {
        +List~Long~ alwaysShow
        +List~Long~ neverShow
        +List~Long~ pinnedDialogs
        +String name
        +String emoticon
        +int flags
        +int color
        +String entities
        +boolean title_noanimate
    }

    class FilterCreateActivity {
        +saveFilterToServer(Filter filter, int flags, String emoticon, String name, String entities, boolean title_noanimate, int color, List alwaysShow, List neverShow, List pinnedDialogs, boolean atBegin, boolean newFilter, boolean async, boolean force, boolean progress, BaseFragment fragment, Runnable onFinish)
    }

    note for Filter "Added entities and title_noanimate fields for server sync"
Loading

File-Level Changes

Change Details Files
The saveFilterToServer method call now includes the entities and title_noanimate parameters.
  • Added filter.entities and filter.title_noanimate to the saveFilterToServer method call when adding a chat to a folder.
  • Added filter.entities and filter.title_noanimate to the saveFilterToServer method call when removing a chat from a folder.
TMessagesProj/src/main/java/org/telegram/ui/ProfileActivity.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @risin42 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@risin42
Copy link
Contributor Author

risin42 commented Feb 5, 2025

Okay, let me add some details.

Steps to Reproduce:

  1. On any Profile View, select 'Add to folder' from the menu and make any changes (either add to or remove from a folder).
  2. Go back to the dialog list. You'll see the changes locally, but it's not visible to other clients (it hasn't been saved to the server).
  3. Restart the app. The changes are reverted.

This can be reproduced on any build after 11.7.0(1204).

@NextAlone
Copy link
Owner

Seems good

@NextAlone NextAlone merged commit fe60e7a into NextAlone:dev Feb 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants