fix handling replica info result

Nextdoor · May 7, 2024 · cc95230 · cc95230
1 parent 232af0a
commit cc95230
Showing 1 changed file with 13 additions and 2 deletions.
diff --git a/rediscluster/slotrange.go b/rediscluster/slotrange.go
@@ -215,11 +215,22 @@ func (s *shard) setReplicaInfo(res interface{}, n uint64) {
 	} else if n&1 == 0 {
 		str, ok := res.(string)
 		haserr = !(ok && str == "OK")
-	} else if buf, ok := res.([]byte); !ok {
+	}
+
+	var buf []byte
+	switch v := res.(type) {
+	case []byte:
+		buf = v
+	case redis.ByteResponse:
+		buf = v.Val
+	default:
 		haserr = true
-	} else if bytes.Contains(buf, []byte("master_link_status:down")) || bytes.Contains(buf, []byte("loading:1")) {
+	}
+
+	if bytes.Contains(buf, []byte("master_link_status:down")) || bytes.Contains(buf, []byte("loading:1")) {
 		haserr = true
 	}
+
 	for {
 		oldstate := atomic.LoadUint32(&s.good)
 		newstate := oldstate