Feture/#9 service #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
likppi10
reviewed
Feb 12, 2025
| @StringRes val traitsResIdList: PersistentList<Int>, | ||
| @StringRes val traitsResIdList: PersistentList<Int>, | ||
| @DrawableRes val alarmBackgroundImageList: PersistentList<Int>, | ||
| val alarmMentList: List<List<Int>>, |
There was a problem hiding this comment.
여기도 PersistentList이면 좋을 것 같아!
There was a problem hiding this comment.
음 ! 여기에 우선 구현해놓긴 했는데..
알람 화면에서 사용되는 고정값들을 새로운 data class로 구성하려고 하는데 어떨까 ?!
그 작업 하면서 옮기려고 생각하고 있었습니닷 , 그 떄 PersistentList 사용할게 !
app/src/main/java/com/ggaebiz/ggaebiz/presentation/service/TimerService.kt
Show resolved
Hide resolved
app/src/main/java/com/ggaebiz/ggaebiz/presentation/service/TimerService.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/ggaebiz/ggaebiz/presentation/service/TimerService.kt
Show resolved
Hide resolved
app/src/main/java/com/ggaebiz/ggaebiz/presentation/service/TimerService.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈
작업 내용
🚨 참고 사항
없습니다 !
📷 스크린샷
없음