Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CAT-98] API request & AuthService #15

Merged
merged 10 commits into from
Aug 5, 2024
Merged

[CAT-98] API request & AuthService #15

merged 10 commits into from
Aug 5, 2024

Conversation

Jihyun247
Copy link
Collaborator

[#98] FEAT : API request 및 AuthService 구현

관련된 문서 📄

무엇에 관한 PR 인가요? 🙋

API request 및 AuthService 구현

어떤 것을 작업하셨나요? 🛠

  • api request loader를 통해 서버통신
  • authService에 토큰 관련 api를 예시로 구현

🌱 PR Point

  • Sources에 위치한 APIRequestLoader 에 대하여 .... 우선 더 시간들여 수정하기 전에 pr 올리는게 낫겠다 싶어 피알포인트로 남겨욥 ㅜ
  • 토큰 인터셉터는 해당 이슈 말고 스플래시 뷰 관련 이슈에서 마무리 지어 합치겟슴다

@Jihyun247 Jihyun247 added the enhancement New feature or request label Aug 3, 2024
@Jihyun247 Jihyun247 self-assigned this Aug 3, 2024
@linear Linear
Copy link

linear bot commented Aug 3, 2024

CAT-98 [iOS] 토큰 처리 구현

@Jihyun247 Jihyun247 changed the title Feature/cat 98 [CAT-98] API request & AuthService Aug 3, 2024
devMinseok
devMinseok reviewed Aug 4, 2024
View reviewed changes
Copy link
Member

@devMinseok devMinseok left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어!
추가로 AuthService 모듈 Project.swift파일이 없는데 이것도 확인해줘~
make graph로 모듈 그래프도 업데이트 해주면 좋을거 같아! <- 요건 자동화를 해놓던가 해야겠다

Projects/Core/APIClient/Interface/Model/TargetTypeInterface.swift Outdated Show resolved Hide resolved
Projects/Core/APIClient/Interface/TokenInterceptorInterface.swift Outdated Show resolved Hide resolved
Projects/Domain/AuthService/Interface/API/AuthAPIClientInterface.swift Outdated Show resolved Hide resolved
Projects/Domain/AuthService/Sources/API/AuthAPIClient.swift Outdated Show resolved Hide resolved
Projects/Shared/Shared/Sources/Exports.swift Outdated Show resolved Hide resolved
@devMinseok
Copy link
Member

병합 전에 feature/CAT-98 <- develop 대상으로 rebase후 conflict는 있으면 수정 해줭!

@devMinseok
Copy link
Member

APIClient의 Preview폴더는 내가 처음에 만들때 들어간거 같은데 제거하면 좋을거 같아!

@Jihyun247
Copy link
Collaborator Author

병합 전에 feature/CAT-98 <- develop 대상으로 rebase후 conflict는 있으면 수정 해줭!

apiclient preview 삭제 코멘트까지 반영 완료햇슴다,, . 누락된 것도 다 올렸어욥

@Jihyun247 Jihyun247 merged commit e944819 into develop Aug 5, 2024
1 check passed
@Jihyun247 Jihyun247 deleted the feature/CAT-98 branch August 5, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devMinseok devMinseok devMinseok approved these changes

Assignees

@Jihyun247 Jihyun247

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jihyun247 @devMinseok