[AUD-97] 새 코스 만들기 기능 구현 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
모달 PR Merge 이후 모달 제작하고, 이후에 해당 PR도 Merge 하면 될거 같습니다. |
|
@RookieAND |
RookieAND
approved these changes
Feb 28, 2024
src/apis/course/index.ts
Outdated
| @@ -88,12 +88,14 @@ export const CourseRepository = { | |||
| }, | |||
|
|
|||
| async postSaveCourseAsync({ | |||
| userId, | |||
There was a problem hiding this comment.
userId 를 굳이 넣지 않아도 됩니다. DOCS 가 이상한거라고 하셔서요
src/apis/course/index.ts
Outdated
| @@ -88,12 +88,14 @@ export const CourseRepository = { | |||
| }, | |||
|
|
|||
| async postSaveCourseAsync({ | |||
| userId, | |||
| courseName, | |||
| }: CourseRequestParamType['postSaveCourse']) { | |||
| return postAsync< | |||
| ApiResponseType<CourseResponseType['postSaveCourse']>, | |||
There was a problem hiding this comment.
postAsync 의 response 에서 data만 보내줘도 죌거 같아요
- Framer 디자인에 맞춰서 스타일 수정
- 코스가 만들어지면 바로 해당 코스로 이동함
KimGaeun0806
force-pushed
the
feature/AUD-97
branch
from
10d3a53 to
bc543b1
Compare
|
@RookieAND 이 친구도 마찬가지로 인풋디자인은 추후 수정 예정입니다~~
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📃 변경사항
🫨 고민한 부분
🎇 동작 화면
2024-02-28.2.38.12.mov
💫 기타사항 (optional)