feat: Confirm 컴포넌트 구현 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boolti-admin ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for boolti-super-admin ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for boolti-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alstn2468
reviewed
Jan 29, 2024
|
|
||
| return useCallback( | ||
| (message: React.ReactNode, buttonText?: ConfirmButtonText) => { | ||
| return new Promise<boolean>((resolve) => { |
There was a problem hiding this comment.
const result = confirm()의 형태로 Confirm 컴포넌트를 사용하려면, 컴포넌트가 띄워지고, 확인/취소 버튼 중 어떤 것이 눌렸는지 결과가 바로 반환되는 것이 아니기 때문에 Promise로 resolve해야 한다고 생각했어. 다른 방법이 있을까?
alstn2468
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirm 컴포넌트 구현
사용 예시는 HomePage.tsx를 참고해주세요.